solidjs / solid / 34891697404

71%

main: 89%

push

github

fix(signals): held-input rules — a staged read enters the transaction, dependencies are the committed frame's (#3408, #3410) (#3431)

Two sides of one gap. The engine already says "the staged world belongs
to its transaction" for writes (setSignal on a stamped node enters it)
and for stamped recomputes (recompute's head enters it). Reads and
dependency trimming did not.

a signal a transaction holds. Non-stale readers are served the staged
value (readers keep speculation), but nothing joined the reader to the
hold, so it published a value derived from the held world into the
mainline frame (`Panel: 1` beside `Count: 0`). `enterStagedRead`: a
tracked computation served a live transaction's `_pendingValue` enters
the transaction, on each of read()'s value selections (both fast paths
and the slow path). No-op for the ambient batch, the active transaction,
and probe reads.

stopped reading count and trimmed the edge, so a later count write never
reached the memo whose committed value still derived from it (`Count: 1`
beside `Selected: 0` / `Fixed: false`). Dependencies are the committed
frame's until the frame is replaced — the deps twin of held children
(#3404): a pass that staged its value leaves the previous pass's tail
linked and `commitPendingNode` trims it (after a clean pass; `_error`
set means the last pass threw and `_depsTail` marks where it stopped).
The write then dirties the stamped memo, which enters the hold, exactly
as an unconditional count() read does. Decided at commit because a plain
flush knows nothing at recompute time: the transaction that holds the
pass may open later in the same flush.

Both now reveal atomically at the landing. +123 B core floor (conscious
bump), eight brotli caps ratcheted by 0.05 KB with notes. No existing
expectation moved.

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.09 hits per line