bedrock-kv / bedrock / a527f4e93f8287209d5b8e78e0173d484f32c30a-PR-328

82%

develop: 82%

Build Type

Pull #328

github

Committed by jallum

Commit Message

bedrock-1cp: Resolve the cluster's object storage backend in one place

Four sites found the backend for themselves and disagreed. The coordinator
and director read the node config's top level (each with its own path
fallback order), the cluster supervisor handed the foreman whatever sat in
its capability sections, and Olivine snapshots read the application config
with a tmp-dir default. A config honored by one site split the cluster's
durable state: workers on S3 while each node kept its own bootstrap on
local disk, or snapshots in /tmp beside chunks under the node's path.

ObjectStorage.Config.cluster_backend/1 is now the only resolution:
top-level :object_storage (normalized, so the :s3 shorthand works), else
LocalFilesystem at <first role path>/object_storage. The coordinator and
director call it; the foreman gets it from the cluster supervisor and hands
it to every worker, Olivine included.

The two placements that used to be half-honored now fail startup rather
than being consulted or overridden: :object_storage inside a capability
section (it reached only the foreman), and an application-config :backend
(it reached only snapshots, so honoring it would send an upgraded
coordinator looking for a bootstrap that was never written there). Docs move
to the node-config form; the CHANGELOG spells out which data moves.

Pull Request Pull Request #328: bedrock-1cp: resolve the cluster's object storage backend in one place

Coverage Stats

21 of 22 new or added lines in 6 files covered. (95.45%)

3 existing lines in 3 files now uncovered.

7187 of 8777 relevant lines covered (81.88%)

1159.32 hits per line