solidjs / solid / 34886627622

77%

main: 89%

push

github

feat(solid,web,signals): server diagnostics on OBSERVE.diagnostics; OBSERVE.server owned by solid-js's server entry (#3433)

The server runtime reports on the same structured channel as the client
(server-dev-build-plan P1 + P2, one PR). Two helper modules hold the gates
— packages/solid/src/server/diagnostics.ts and packages/web/src/diagnostics.ts
— with three verbs: emitFinding (observe + dev: emit, and in dev report
through DEV.report), recordFinding (emit only, for a site that throws its
message), devCheck (emitFinding behind the dev gate). Call sites are wrapped
in literal "_SOLID_OBSERVE_" / "_SOLID_DEV_" tests so Rollup drops the
message strings from the tiers below; the prod server artifacts carry none
of it.

Findings (observe + dev): SSR_RENDER_ERROR_CONTAINED (data.handling:
fallback from createErrorBoundary, client/failed from the Loading boundary's
routing, failed from the root — the structured face of renderToStream's
onError, on the process-wide channel), SSR_SUBTREE_ABANDONED,
SSR_STREAM_ABANDONED (consumer | sink), LATE_HEADER_WRITE (recorded beside
the dev throw / prod log), SERVER_FN_ERROR_SANITIZED (the original the wire
replaced), FRAME_MARKER_CORRUPTED (frames client).

Checks (dev): every server console.warn becomes a code — SERVER_WRITE,
REVEAL_IN_RENDER_TO_STRING, LAZY_ASSET_UNMAPPED, PRELOAD_DESCRIPTOR_INVALID,
HEAD_TAG_INVALID, BEHAVIOR_CLAIM_DROPPED, UNRECOGNIZED_INSERT_VALUE (one code
and a new `render` kind on both platforms; the client's console.warn is
converted too). ASYNC_OUTSIDE_LOADING_BOUNDARY on the server records with
data.side: "server" before it throws. DiagnosticKind gains ssr, head, render.

ownerPath: the server createComponent runs the body under a transparent
owner labelled <Name> in observe/dev (createComponentOwner — no hydration id
consumed, no ownerCreations tick); the core's ownerPath walk reads
SSROwner._parent/_name unchanged. The repair-guide console footer moves to
src/console-footer.ts and both e... (continued)

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 2 files covered. (100.0%)

772 of 1007 relevant lines covered (76.66%)

15.07 hits per line