bedrock-kv / bedrock / 35ae854ab6d8e409cd68014614c5c845e3531f37

82%

Build Type

push

github

Committed by web-flow

Commit Message

bedrock-q67.21.14: Rename components to match their clarified purposes (#304)

The q67.21.9 to .13 stack changed what several recovery and distributor
components do, and their names kept describing the old behaviour. This
is the deferred rename pass, landed last so nothing is renamed twice. No
logic changes.

Ticket: bedrock-q67.21.14
Stacked on: #303 (bedrock-q67.21.15/exclusion-safety-log-record)

## Why

Names here are read as claims about the code, and five had become false.
`MaterializerBootstrapPhase` claimed recovery seats materializers for
every shard. Since #263 it creates or adopts exactly one, for tag 0, so
that recovery can read the metadata families that live there; placing
data-plane materializers is the distributor's job. `TSLValidationPhase`
claimed to check a transaction system layout. It has only ever received
the prior durable record, which since #200 is a `CoreState` holding
`logs` and `system_materializers` and nothing else. The stall reason
`:corrupted_tsl` and the `:tsl_validation_*` telemetry pointed an
operator at the wrong artifact.

`materializer_refs` in the distributor snapshot and
`prior_materializer_refs` on the attempt read as one callable ref per
tag. Since bedrock-q67.21.9 the family is a set, `%{tag => %{worker_id
=> node}}`, and every reader iterates it as one. `shard_materializers`
implied recovery still decides membership for many shards.

## What changed

- `MaterializerBootstrapPhase` becomes `SystemShardBootstrapPhase`; its
read-failure reason is `{:prior_members_query_failed, _}` and the test
hook is `:read_prior_members_fn`.
- `TSLValidationPhase` becomes `CoreStateValidationPhase`; the stall
reason is `{:corrupted_core_state, _}` and the events are `[:bedrock,
:recovery, :core_state_validation_success | _failed]` with metadata key
`core_state`.
- `TSLTypeValidator` becomes `TypeSafetyValidator`, not the ticket's
`CoreStateValidator`: its assertive half runs on the real layout in
`TopologyPhase`, whose `resol... (continued)

Coverage Stats

41 of 44 new or added lines in 10 files covered. (93.18%)

181 existing lines in 11 files now uncovered.

7177 of 8795 relevant lines covered (81.6%)

1163.05 hits per line