axkit / velum / 34872142433

88%

push

fix InTx committing on error

InTx in pgxw and sqlw declared an unnamed result, so `return fn(tx)` never
assigned to `err`. `err` stayed nil from Begin, the deferred func always took
the Commit branch, and `err = tx.Commit(ctx)` was dead: the error from fn was
returned to the caller while the transaction was committed anyway. Commit
errors were dropped the same way.

Name the result in both wrappers. logw.Wrapper.InTx rolled back correctly but
dropped commit errors for the same reason; name its result too and drop the
now redundant fnErr.

Add integration tests (intx_test.go) covering rollback on error, commit on
success and a deferred-constraint COMMIT failure, plus a logw unit test for
commit error propagation. All three fail without the fix.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RbWkiykV7LXmzE9sqdypVP

5 of 6 new or added lines in 3 files covered. (83.33%)

1582 of 1772 relevant lines covered (89.28%)

1.0 hits per line