scikit-hep / iminuit / 34871389235

100%

push

github

fix: accumulate FMin.time correctly across migrad/hesse/minos (#1194)

:robot: _AI text below_ :robot:

`_Timer` in `src/iminuit/util.py` was meant to add elapsed time to the
previous total, but `__exit__` computed `monotonic() - value` instead of
`value + monotonic()`. For example, after `m.migrad()` followed by
`m.hesse()`, `m.fmin.time` became negative instead of the sum of both
runtimes. The fix makes `__enter__` subtract the start time and
`__exit__` add the end time, so `value` accumulates correctly. Added a
unit test for `_Timer` and an integration test that checks `fmin.time`
grows after `migrad()` then `hesse()`.

Part of #1192

5 of 5 new or added lines in 1 file covered. (100.0%)

3961 of 3972 relevant lines covered (99.72%)

1.0 hits per line