ThePalaceProject / web-patron / 34870513326

26%

push

github

Visual and accessibility audit of i18n changes (PP-4711) (#198)

Some minor changes to fix some visual and accessibility issues caused
when translations were added:
- Prevent `LanguageSelector` from being hidden behind book covers in
mobile view
- <img width="140" height="250" alt="Screenshot 2026-09-09 at 8 51
37 AM"
src="https://github.com/user-attachments/assets/200e5be0-b4d9-495f-a5a9-fbf7fb5a898d"
/>

- Provide localized title for `Search` component
- The only instance of the `Search` component is being used in the
header to conduct catalog-wide searches. The value returned on
`searchData.shortName` cannot be guaranteed to be any particular value,
but the majority of libraries provide "Search" as its value for which a
translation can be provided. If any other value is provided that is not
found in the translations, then the value from `searchData.shortName`
will be used.

> [!NOTE]
> `SearchData.shortName` should never be null or undefined, but because
`searchData` has been optionally chaining `shortName` then we'll
maintain that check and provide an alternative value in case of any
unlikely runtime errors.

<!--- Describe your changes -->

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
A final audit was needed to ensure translations met accessibility
standards and that translations did not change or break visual layout of
the UI:
- The `LanguageSelector` menu was not usable on small screen sizes.
- The `title` attribute of inputs must be localized in order to meet
accessibility standards.

[Jira PP-4711](https://ebce-lyrasis.atlassian.net/browse/PP-4711)

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
- Tested manually from local server
- E... (continued)

353 of 1503 branches covered (23.49%)

Branch coverage included in aggregate %.

730 of 2090 relevant lines covered (34.93%)

9.76 hits per line