vocdoni / vocdoni-node / 34856314267

66%

main: 65%

Build Type

Pull #1460

github

Committed by altergui

Commit Message

chore: purge legacy consensus code paths

Drop legacy compat scaffolding that was explicitly waiting for the
LTS/1.2 → LTS/1.3 chainID bump:

- vochain/ist/legacy.go: entire file — legacy gob-encoded IST action
  format from before commit 1a5a56e ("adapt to timestamp based
  blockchain"). Comment in-file already stated "this whole legacy.go
  code can be removed once LTS 1.2 chain is upgraded". Along with its
  call site in ist/store.go (findPendingActions no longer branches on
  the "gob: type mismatch" tell-tale) and its dedicated
  TestISTCMigrateLegacy test.
- vochain/transaction/transaction.go: soft-fork gate for LTS/1.2
  (chainID=="vocdoni/LTS/1.2" && height<4138989) around the IST
  Reschedule on SET_PROCESS_DURATION. The window is long past on
  every live chain; SET_PROCESS_DURATION now always schedules.
- vochain/start.go: migrateLegacyDirs — filesystem migration for
  node data-dir layout from before "refactor genesis package" (>2 y).
  Any operator still on that layout has to have upgraded via an
  intermediate release long ago.

Kept for follow-up PRs (bigger scope than expected):
- Block-count based process/vote acceptance: rejecting these requires
  migrating ~40 tests across vochain/indexer/api that construct
  processes with BlockCount instead of Duration. Comments/TODOs on the
  dual paths in election_tx.go and vote_tx.go remain in place; scope
  belongs in its own PR.
- arboproof address-hashing and LeafWeight==nil legacy: verifier-side
  change coupled to census construction on the client (SDK) side;
  needs coordinated release, not a unilateral bump.
- ProcessBlockRegistry / SIK invalidation: tied to timestamp-based
  election deadline semantics; requires a rework of the "max end
  block" check.

Net: +6/-249, all tests still pass under
`go test ./vochain/... ./api/...`.

Pull Request Pull Request #1460: chore: purge legacy consensus code paths

Coverage Stats

1 of 4 new or added lines in 2 files covered. (25.0%)

2 existing lines in 2 files now uncovered.

18227 of 27476 relevant lines covered (66.34%)

41371.17 hits per line