AfterShip / clickhouse-sql-parser / 34832748941

56%

Build Type

push

github

Committed by web-flow

Commit Message

Establish complete source spans and diagnostics (#328)

Make token-backed AST spans complete half-open byte ranges for strings,
placeholders, stars, function calls, query parameters, and set-operation
queries. Improve caret rendering for tabs and Unicode while preserving
byte-based diagnostic columns.

Before applying this PR:

Several exported spans excluded delimiters or were empty, including string
literals, function calls, stars, placeholders, and query roots with set
operations. Caret indentation treated byte offsets as display columns.

After this PR:

These nodes cover their complete source syntax, query roots contain their
set-operation descendants, and diagnostic carets use terminal display width.
AST golden files record the intentional span migration.

Verification:

- make test passed.
- make update_test passed.
- make lint remains blocked because golangci-lint v1.53.3 rejects the
  repository configuration format.

Migration note: consumers relying on historical string or function end
positions must adopt complete half-open byte spans.

Assistant-By GPT-5

Coverage Stats

39 of 45 new or added lines in 6 files covered. (86.67%)

1 existing line in 1 file now uncovered.

9804 of 17367 relevant lines covered (56.45%)

3471.16 hits per line