cameri / nats-server / 34807436637
75%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 76.659% (-5.9%) from 82.552%
34807436637

push

github

web-flow 
[FIXED] Remove stale JetStream account usage after peer removal (#8570)

Fixes #8563.

When a JetStream server is permanently removed from the cluster, its
last reported account usage can remain in `jsAccount.rusage`. Because
that value is still included in the account totals, replacing a stream
replica on another server can cause storage usage to be counted twice.

I reproduced this with a 4-node cluster and an R3 stream. After removing
one of the replica-holding servers and letting the stream move to the
spare node, the stream was still correctly running with 3 replicas, but
the account storage usage increased as if there were 4 copies.

This change removes the departed server's usage when its meta peer
removal is committed. It also ignores a late usage update from the
removed node so that the stale entry cannot be added back after cleanup.

I added a regression test that:

* creates an R3 stream on a 4-node cluster,
* verifies the initial account usage,
* removes one of the servers hosting a replica,
* waits for the replica to move to the spare server,
* verifies the account usage stays unchanged,
* and checks that a late usage update from the removed peer does not
recreate the stale entry.

Testing:

* new regression test passes repeatedly
* regression test passes with `-race`
* related peer-removal and account-usage tests pass
* `go vet ./server`
* `git diff --check`

66259 of 86433 relevant lines covered (76.66%)

327500.89 hits per line

Coverage Regressions

Lines Coverage ∆ File
2429
24.45
-64.07% src/github.com/nats-io/nats-server/server/mqtt.go
654
62.3
-15.56% src/github.com/nats-io/nats-server/server/opts.go
438
70.33
-16.26% src/github.com/nats-io/nats-server/server/monitor.go
214
44.85
-45.92% src/github.com/nats-io/nats-server/server/msgtrace.go
210
54.32
-13.14% src/github.com/nats-io/nats-server/server/reload.go
205
71.43
-9.67% src/github.com/nats-io/nats-server/server/memstore.go
159
89.04
-3.87% src/github.com/nats-io/nats-server/server/client.go
112
0.0
-52.83% src/github.com/nats-io/nats-server/server/proto.go
101
77.71
-2.21% src/github.com/nats-io/nats-server/server/raft.go
93
85.77
-3.71% src/github.com/nats-io/nats-server/server/leafnode.go
87
86.29
-3.18% src/github.com/nats-io/nats-server/server/server.go
66
81.8
-3.07% src/github.com/nats-io/nats-server/server/route.go
64
82.5
-8.34% src/github.com/nats-io/nats-server/server/parser.go
48
85.43
-0.68% src/github.com/nats-io/nats-server/server/stream.go
37
62.52
-3.46% src/github.com/nats-io/nats-server/server/websocket.go
36
55.97
-22.64% src/github.com/nats-io/nats-server/server/log.go
34
8.11
-91.89% src/github.com/nats-io/nats-server/server/monitor_sort_opts.go
31
84.8
-2.6% src/github.com/nats-io/nats-server/server/auth.go
30
83.8
-1.53% src/github.com/nats-io/nats-server/server/events.go
25
73.29
-0.64% src/github.com/nats-io/nats-server/server/jetstream_api.go
23
82.98
0.1% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
15
77.95
0.02% src/github.com/nats-io/nats-server/server/filestore.go
15
89.07
-1.43% src/github.com/nats-io/nats-server/server/sublist.go
14
85.83
-0.35% src/github.com/nats-io/nats-server/server/accounts.go
12
87.62
0.0% src/github.com/nats-io/nats-server/server/consumer.go
12
10.38
-11.32% src/github.com/nats-io/nats-server/server/signal.go
9
70.49
-14.75% src/github.com/nats-io/nats-server/server/feature_flags.go
8
93.09
-0.34% src/github.com/nats-io/nats-server/server/gateway.go
8
74.42
-4.65% src/github.com/nats-io/nats-server/server/jwt.go
5
91.9
-0.72% src/github.com/nats-io/nats-server/server/jetstream_batching.go
4
84.64
0.05% src/github.com/nats-io/nats-server/server/jetstream.go
2
85.45
-0.94% src/github.com/nats-io/nats-server/server/util.go
1
76.56
-1.56% src/github.com/nats-io/nats-server/server/errors.go
Jobs
ID Job ID Ran Files Coverage
1 34807436637.1 66
76.66
GitHub Action Run
Source Files on build 34807436637