solidjs / solid / 34807940390

78%

main: 89%

push

github

fix(signals): isPending() true for a sync memo held by a downstream async memo (#3413) (#3417)

A synchronous memo recomputed in a plain flush skipped its companion sync
because no transition was active yet. When a downstream async memo then
pended, the batch was adopted into a transaction and the memo was held,
but its pending signal still carried the pre-stage "false", so
isPending(memo) disagreed with isPending(signal) until the hold committed.

Gate the sync on CONFIG_HAS_COMPANIONS like setSignal does, instead of on
an active transition.

Co-authored-by: Brenley Dueck <brenleydueck@Brenleys-Mac-mini.local>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.02 hits per line