apereo / cas / 34794697644-1

90%

push

github

fix: property prefixes on the DynamoDb events and Cloudwatch logging docs pages

Anyone setting up DynamoDb authentication events or CloudWatch logging is told there's nothing to configure. Both pages print the "The following settings and properties are available from the CAS configuration catalog" heading and then a table with no rows under it, so theres no sign anything failed and the build stays green.

Here are the two pages as published today, next to a sibling that works:

```
$ grep -c 'cas\.events\.' Configuring-Authentication-Events-DynamoDb.html
0
$ grep -o 'cas\.events\.redis\.[a-z.-]*' Configuring-Authentication-Events-Redis.html | sort -u | wc -l
46
$ grep -c 'cas\.logging\.cloudwatch' Logging-Cloudwatch.html
0
```

`casproperties.html` splits the requested prefixes on commas and then matches them against the generated catalog with `config.name contains prop`. Plain substring, no relaxed binding anywhere in that path, so the prefix has to be the catalog key exactly.

Worth saying about the CloudWatch one: `cas.logging.cloud-watch` is fine in a user's configuration, since relaxed binding drops the hyphen. It just can't match the catalog key this include is looking up. Quiet way to fail.

I checked the other 499 prefixes accross the doc set rather than only these two. The partial ones that look wrong (`cas.authn.x509.ssl-header` and friends) are deliberate and resolve through the substring match. These two are the only pages that render empty. Master only, since the maintenence branches want their own cross-referenced pull requests.

Ten other doc pages already spell the DynamoDb prefix `dynamo-db`, and `CasAmazonCloudWatchLoggingConfiguration` reads `casProperties.getLogging().getCloudwatch()`.

- [x] Brief description of changes applied
- [ ] Test cases for all modified changes, where applicable
- [ ] Test cases to demonstrate the problem before the fix, where applicable
- [ ] The same pull request targeted at the master branch, if applic... (continued)

14815 of 20727 branches covered (71.48%)

Branch coverage included in aggregate %.

84226 of 89658 relevant lines covered (93.94%)

36.57 hits per line