Eyevinn / mp4ff / 34780584245

82%

master: 82%

Pull #581

github

fix(mp4): reject ftyp and styp boxes with a payload shorter than 8 bytes

MajorBrand slices data[:4] and MinorVersion slices data[4:8] with no
guard, and CompatibleBrands computes (len(data)-8)/4, which goes
negative. A box declaring an 8-byte size therefore decoded without
error and then panicked on first access:

  $ mp4ff-info short.mp4
  [ftyp] size=8
  panic: runtime error: slice bounds out of range [:4] with capacity 0

Check the payload length at decode, the way DecodeSdtpSR, DecodeMimeSR
and DecodeFrmaSR already do.

styp needs two guards because DecodeStyp does not delegate to
DecodeStypSR the way DecodeFtyp does.

9 of 9 new or added lines in 2 files covered. (100.0%)

22109 of 26932 relevant lines covered (82.09%)

0.82 hits per line