aio-libs / multidict / 34777395901

87%

push

github

Feat: add the to_dict() (#1288)

## What do these changes do?

Implement `to_dict()` methods for `MultiDict`, `CIMultiDict`,
`MultiDictProxy`, and `CIMultiDictProxy`. This method groups values with
the same key into a list.

### Implementation Details

- **C Extension**: Added `multidict_to_dict` in `_multidict.c` with
direct `PyDict` and `PyList` manipulation for performance.
- **Python Fallback**: Added generic `to_dict` in `_multidict_py.py`.
- **Tests**: Added comprehensive test coverage in
`tests/test_to_dict.py`, including verification of order preservation,
case-insensitivity, mixed types, and proxy mutation isolation.
- **Memory Safety**: Added a new isolated leak check
(`tests/isolated/multidict_to_dict.py`) and integrated it into the CI
suite (`tests/test_leaks.py`). Validated with intentional leak inserted
in code (removed after test).

### Example

```python
md = MultiDict([("a", 1), ("b", 2), ("a", 3)])
md.to_dict()

# Result: {'a': [1, 3], 'b': [2]}
```

## Are there changes in behavior for the user?

No existing behavior changes. This adds a new method `to_dict()` 

## Related issue number

Fixes #783 (Add `to_dict` method)

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [x] Documentation reflects the changes

---------

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>

663 of 1326 branches covered (50.0%)

Branch coverage included in aggregate %.

196 of 203 new or added lines in 5 files covered. (96.55%)

4746 of 4979 relevant lines covered (95.32%)

1.91 hits per line