rm-hull / zaup2 / 34748962611
92%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 1
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
34748962611

push

github

web-flow 
Upgrade protobuf implementation (#1351)

* refactor(protobuf): migrate from google-protobuf to Buf ES

Migrate the protocol buffer code generator and dependencies from
`google-protobuf` to `@bufbuild/protobuf` and `protoc-gen-es` using
Buf.

- Replaced legacy `google-protobuf` packages with `@bufbuild/protobuf`
- Updated `package.json` generate script to use `buf generate`
- Refactored application code to use modern ES-targeted protobuf types
  and serialization functions (`fromBinary`, `toBinary`, `create`)

* Fix protobuf serialization causing QR code import failure

The migration to @bufbuild/protobuf introduced two issues:

1. Binary serialization in ImportURL.tsx was corrupting protobuf data
   by using TextDecoder to decode binary data as UTF-8 before base64
   encoding. Fixed by converting the Uint8Array directly to base64.

2. JSON serialization in CryptoJsSerializer was failing because the new
   protobuf library returns native Uint8Array objects for byte fields
   and bigint for 64-bit integer fields, which JSON.stringify cannot
   handle. Added custom JSON replacer/reviver to properly serialize/
   deserialize these types to/from localStorage.

* Fix bigint serialization issues after protobuf migration

The @bufbuild/protobuf migration introduced several issues:

1. Uint8Array and bigint serialization: The new library returns native
   Uint8Array for byte fields and bigint for int64 fields. JSON.stringify
   cannot handle bigint values, causing errors in @rm-hull/use-local-storage
   which uses JSON.stringify internally for equality comparison.

2. Counter field type change: Changed OTP type to use number instead of
   bigint for the counter field, as it's only used for HOTP counters
   which don't need the full bigint range.

3. Base64 encoding fix: Fixed binary serialization in ImportURL.tsx that
   was corrupting protobuf data by incorrectly using TextDecoder before
   base64 encoding.

4. Added JSON replacer/reviver in CryptoJsSerialize... (continued)

4 of 4 relevant lines covered (100.0%)

1.75 hits per line

Jobs
ID Job ID Ran Files Coverage
1 34748962611.1 1
100.0
GitHub Action Run
Source Files on build 34748962611