polserver / polserver / 34745661796

82%

Build Type

push

github

Committed by web-flow

Commit Message

Repaint the client's weather and light after anything that resets them (#962)

* Repaint the client's weather and light after anything that resets them

The client stops drawing weather when it is sent a new position, and the season
packet resets its light level. Both go out from many places, and only
move_character_to handled the consequence - it nulls the client's remembered
weather region so its own tellmove repaints. Everywhere else the sky stayed
wrong until the character crossed into another weather region, teleported, or
the weather changed on its own.

Both halves are measured, not inherited. The tree only ever hedged on the
weather half - "send_goxyz seems to stop the weather" beside the null in
move_character_to, and dave's 2003 note in check_weather_region_change,
"send_goxyz causes weather effects to stop if character is walking/running too".
Sending a bare, well-formed 0x20 to a standing character in the rain, with no
repaint behind it, stops the weather: the sky goes clear and stays clear. So the
effect is real and the walking/running qualifier is not limiting. For the light,
send_season_info's own comment says the season packet resets it, and an undated
POL097 entry records the intent that the core "sends light level whenever season
info is sent to the client".

Repaints added at: the client's resync request, death, resurrection, a graphic,
colour or facing change, the gargoyle fly toggle, the client version handshake,
and a boat crossing realms. Login already had one, but it went out before the
season packet and the final send_goxyz and so undid itself - that one moves
rather than appears. Only the handshake rests on the season premise; it sends no
position packet at all. The rest stand on send_goxyz alone.

The boat repaint has to sit below the branch that sends goxyz to pre-7.0.9.0
clients, or that undoes it, and has to be forced: region grids are zero-filled
per realm and the lookup indexes one shared vector, so an unpainted zone in... (continued)

Coverage Stats

42 of 50 new or added lines in 9 files covered. (84.0%)

35 existing lines in 5 files now uncovered.

59050 of 72621 relevant lines covered (81.31%)

1523197.64 hits per line