CyclopsMC / IntegratedDynamics-Compat / 34742330919

10%

master-26-lts: 39%

Pull #42

github

Update ModDevGradle to 2.0.147 to fix stale patched Minecraft on CI

CI failed on the NeoForge bump with:

  NoSuchMethodError: 'void net.neoforged.neoforge.internal.DataComponentModifiers
  .apply(net.minecraft.world.item.Item, net.minecraft.core.component.DataComponentMap$Builder)'

That two-argument signature only exists in 26.1.2.22-beta; 26.1.2.109 takes
a HolderLookup.Provider as well. The call came from the patched Minecraft
jar, so it had been built from the old patches and only named after the new
version.

ModDevGradle disables recompilation when the CI environment variable is set,
which switches NeoFormRuntime to its binaryPatch path. In 2.0.141 that step's
cache key does not account for the NeoForge version, so a warm cache returns
the previous version's patched jar. Local builds never hit it, since they take
the decompile/recompile path instead.

Reproduced locally with CI=true: building 26.1.2.22-beta and then 26.1.2.109
reuses the cached binaryPatch output and emits the old patches. On 2.0.147 the
step re-runs, each version keeps its own entry, and cycling between versions
keeps returning the right jar.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JpfdmgsyiKsvxjztpcvqpK

69 of 362 branches covered (19.06%)

Branch coverage included in aggregate %.

678 of 1566 relevant lines covered (43.3%)

1.92 hits per line