bleedingdeacons / link / 34702662379
92%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 22
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.986% (+0.07%) from 92.917%
34702662379

push

github

web-flow 
fix: log why the server refused, not just that it did

A refused request wrote its status and nothing else, while the sentence
explaining it sat unread in the response body. Every caller already pulls
that sentence out and puts it on screen, so the member saw the diagnosis
and the log did not.

That cost an afternoon today. A handset logged "POST messages refused
with 400" and Fellowship answers 400 for three unrelated reasons -- an
audience the app may not send to, a subject or body it would not take,
and a message addressed to nobody once the sender is struck off their own
recipient list. Separating them meant reading the server's source. The
body had said "That message would not reach anybody." all along.

Both refusal paths now append it. Only the response is read: a request
body on the POST route can carry a password and still never reaches the
log, which is what the old comment was protecting and remains true.

Reading it there is safe rather than merely lucky. The default
ResponseContentRead has already buffered the content by the time
SendAsync returns, so the caller's own read still gets the whole body --
pinned by a test, because a destructive read here would leave the member
with the generic wording and put the real reason only in the log, which
is precisely the fault being fixed, inverted.

Only the message field is taken, never the body wholesale: a gateway
having a moment answers with a page of HTML, and that belongs in a log
line even less than a bare status does.

1233 of 1326 relevant lines covered (92.99%)

15.26 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
96.19
0.13% Services/FellowshipClient.cs
Jobs
ID Job ID Ran Files Coverage
1 34702662379.1 22
92.99
GitHub Action Run
Source Files on build 34702662379