|
Ran
|
Jobs
1
|
Files
147
|
Run time
1min
|
Badge
README BADGES
|
push
github
fix(chart): the Helm chart could not bring up a Valkey instance (#123) * fix(chart): sync the bundled CRDs with the generated ones The chart ships its own copy of the CRDs under crds/, which Helm installs on first install and never upgrades. Nothing kept that copy in step with config/crd/bases, and it had drifted far enough to be wrong in two ways that reach users: - rds.valkey.buf.red_valkeys pinned spec.version to an enum of 7.2/8.0/8.1. It predates 9.0/9.1 support, so a chart install rejected 'version: "9.0"' and 'version: "9.1"' outright -- the two versions the README and the docs matrices list as supported. - valkey.buf.red_users had no status.phase property at all and printed the PHASE column from .status.Phase. That is the pre-#101 spelling; the fix landed in config/crd/bases and never reached the chart, so a chart-installed User showed an empty PHASE and could not persist the field through the status subresource. Everything else that moved is corev1 description text, which changed with k8s.io/api 0.35.2 -> 0.37.0 earlier on this branch. make manifests now copies the generated CRDs into the chart so the two cannot diverge again. That is the actual defect here: the copy was maintained by hand with nothing to catch it falling behind. (cherry picked from commit 2b8bec912) * fix(chart): stop emitting a double-tagged valkey-helper image Every instance created by a chart-installed operator failed with InvalidImageName, so the Helm path -- the one the README recommends -- could not bring up a Valkey instance at all. The operator derives the valkey-helper image by appending ":$OPERATOR_VERSION" to $OPERATOR_IMAGE_NAME (config.GetFullImageURL). That name must therefore carry no tag, and its in-code default, "chideat/valkey-operator", does not. The chart was setting it from valkey-operator.image, which is the full reference including the tag, so the helper image came out as ghc... (continued)
5489 of 20764 relevant lines covered (26.44%)
0.3 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 2 |
74.19
|
-1.61% | cmd/helper/sync/file.go |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 34698319084.1 | 147 |
26.44
|
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|