tortoise / tortoise-orm / 34682824973

85%

master: 94%

push

github

Inherit Meta.ordering from abstract base models (#2046) (#2236)

* Inherit Meta.ordering from abstract base models

When a model defined its own ``Meta`` (e.g. to set ``table``) but did not set
``ordering``, the ordering declared on an abstract base model's ``Meta`` was
lost, because ``ModelMeta.__new__`` reads ``Meta`` only from the class's own
attributes. As a result queries on the subclass came back unordered.

If the subclass's own ``Meta`` does not define ``ordering``, inherit the
default ordering from the first base model that has one. A subclass that
defines its own ``ordering`` (including an explicitly empty one) is
unaffected.

Closes #2046

3203 of 4240 branches covered (75.54%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

11636 of 13299 relevant lines covered (87.5%)

0.87 hits per line