btcsuite / btcd / 34637539728

54%

master: 54%

Build Type

Pull #2607

github

Committed by Roasbeef

Commit Message

netsync: add property-based tests for sync state recovery

In this commit, we add two rapid-based property tests that generalize the regression test for the lost-sync-peer stall.

TestPropertyLostSyncPeerRecovers covers the near-tip disconnect across arbitrary chain heights and remaining-peer height combinations: for any generated scenario, losing the sync peer with IBD enabled must either promote a strictly higher replacement peer (re-entering IBD through the header-first path, which the test drives to completion) or fully reset the sync state so that a new-block announcement from any remaining peer is requested.

TestPropertySyncStateTransition is a stateful property over the whole header-first sync state machine. A generated schedule of events (new peers at arbitrary heights, header and block delivery from the sync peer, stalls, and peer loss) is replayed against the manager, asserting after every event that the dead state (nil sync peer with IBD enabled) in which handleInvMsg discards announcements never holds.

generateTestBlocks now anchors timestamps to the current time rather than the 2011 regtest genesis timestamp. A chain built from the genesis timestamp is never IsCurrent, which keeps the near-tip paths where the stall occurs unreachable; starting from now keeps them reachable at any generated height, which is what lets the properties reproduce the bug. Both properties fail on the parent commit and pass with the fix.

Tests: go test ./netsync/ ./blockchain/ ./peer/ ./mempool/; go test ./...

Pull Request Pull Request #2607: netsync: recover after losing sync peer near tip

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

771 existing lines in 8 files now uncovered.

38073 of 70297 relevant lines covered (54.16%)

369139.87 hits per line