tari-project / tari / 34619019144

75%

Build Type

push

github

Committed by web-flow

Commit Message

test: deflake duplicate-commitment and liveness end-to-end tests (#8004)

Two tests on development fail intermittently, independently of any PR.
`services::liveness::end_to_end` has now been seen on two unrelated PRs
and on two different network legs:

  * run 34581539775 (PR #8002, mainnet/stagenet) - got 15 of 18 items
  * run 34606190029 (PR #8003, nextnet)         - got 17 of 18 items

`it_rejects_a_block_with_two_outputs_sharing_a_commitment` twins
`outputs[0]`, but `Ord for TransactionOutput` compares the commitment
alone, so which output sorts first is random. When that is the coinbase
the twin gives the block two coinbases, and `check_coinbase_outputs`
runs before the sort check, so the test saw `InvalidCoinbase` instead of
`UnsortedOrDuplicateOutput`. Reproduced at 5/20 locally; now twins the
first non-coinbase output and inserts the duplicate next to it.

`services::liveness::end_to_end` counts every ping and pong exactly, but
messages were being dropped. A node re-dials a peer while its own dial
is still in flight, because the pending dial is not yet in the
connection pool. The extra connection that lands is resolved by a
ConnectivityManager tie break which silently disconnects the loser,
taking any message already written to it with it:

    No connection for peer 5023547a... Dialing...      (x3)
    Tie-break: (Existing = Outbound, New = Outbound)
    Tie break: Keep new connection (id: 3). Disconnect existing (id: 1)
    Failed to receive from peer ... 'connection is closed'

Seen as both Outbound/Outbound (one node double-dialling) and
Outbound/Inbound (both nodes dialling each other); in one run both sides
tie-broke in opposite directions and neither reconnected for 30s. The
test now seeds only node 1 with its counterpart so only one side dials -
node 2 learns node 1 from the inbound connection - and waits for
connectivity plus a quiet period on the connectivity event stream before
pinging. 150/150 pass, up from roughly 90%.




<!-- g... (continued)

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

271 existing lines in 13 files now uncovered.

86261 of 137466 relevant lines covered (62.75%)

193345.63 hits per line