aio-libs / multidict / 34612380919

87%

push

github

Replace PyIter_Next() with PyIter_NextItem() in the C extension (#1440)

<!-- Thank you for your contribution! -->

## What do these changes do?

Replaces every `PyIter_Next()` call in the C extension with the newer
`PyIter_NextItem()`. The old API returns `NULL` both when the iterator
is exhausted and when an error propagated, so every call site needed a
follow-up `PyErr_Occurred()` check to tell the two apart.
`PyIter_NextItem()` reports that through its own return code (`1` item,
`0` exhausted, `-1` error), so the ambiguity is gone. The
`pythoncapi_compat.h` shim already vendored in this repo backports it
for Python versions that predate the new API upstream.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it is a mechanical internal refactor with no new public surface.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A: no `CONTRIBUTORS.txt` in this repo)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` (1831 passed) against the default C-extension build;
`MULTIDICT_NO_EXTENSIONS=1 pip install -e . --force-reinstall --no-deps`
+ `pytest -q --no-c-extensions` (925 passed, 905 deselected) for the
pure-Python leg, matching the CI matrix invocation.

Lint: `pre-commit run clang-format --files multidict/_multilib/views.h
multidict/_multilib/hashtable.h` passes; the full commit also went
through the repo's standard pre-commit hooks on `git commit`.

Docs: `make doc-spelling` passes for the content this PR adds. One
pre-existing, unrelated spelling failure already exists on `maste... (continued)

642 of 1284 branches covered (50.0%)

Branch coverage included in aggregate %.

4430 of 4656 relevant lines covered (95.15%)

1.9 hits per line