solidjs / solid / 34577854183

72%

main: 89%

push

github

fix(compiler): extract "use server" function declarations nested in a function (#3369)

The bubbling pre-pass turns every function declaration into
`const name = function name() {}` at the top of its block so the
transform only handles expression forms. Babel skipped the body of each
bubbled declaration (`tmp.skip()`), so a declaration nested inside
another function was never bubbled, never became an expression, and a
directive on it was silently ignored: the body shipped to the client
and ran there. The capture validator walks every function, so the same
declaration still had its captures rejected. One spelling produced a
compile error, the other a client-side body.

The bubbler now descends into each bubbled body, so nested declarations
are extracted like any other marked function, at any depth and inside
nested blocks. The const lands at the top of its block, so a use above
the declaration still resolves. Ids follow the binding path
(`outer.inner`). Only files that extract at least one function keep the
pass's output, so the extra bubbling never reaches a file without server
functions. No existing fixture contains a nested declaration, so the
frozen references are unchanged.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.02 hits per line