solidjs / solid / 34573589784

79%

main: 89%

push

github

fix(compiler): reject a server directive on a method (#3365)

A method, getter, or setter is never extracted by the directive pass, so a
`"use server"` directive on one did nothing at all. The directive string
shipped verbatim in the client bundle and the body kept running wherever it
was called, browser included. The pass reported `valid: false` and said
nothing.

It is now a compile error naming the method and its position, with the
extractable spelling as the fix.

- Covers object literal methods and accessors, and class methods,
  accessors, and constructors.
- Runs in both server and client mode.
- A directive on a method nested inside an already-extracted server function
  is still ignored, since that whole body ships to the server.
- A function assigned to a property or a class field is extracted as before
  and is unaffected.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.03 hits per line