iotaledger / iota-rust-sdk / 34550664853

42%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(types)!: reduce the public surface of iota-sdk-types (#1473)

* refactor(types)!: privatize modules and helpers that duplicate the crate root

Thirteen public modules held nothing that `lib.rs` did not already
re-export, so every type in them answered to two paths and both had to be
kept working forever. `u256` published an empty namespace — its contents
are `pub(crate)` pending the wrapper its own comment asks for.

`write_sep` had no callers at all, so privatizing it would only have moved
the dead-code warning; it goes rather than gaining an `allow`. The two
exported macros expand to `paste::paste!`, which resolves at the call site,
so no external caller could ever have invoked them without depending on
`paste` directly.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(types)!: keep the signer bitmap behind accessors

`ValidatorAggregatedSignature.bitmap` was a `pub` field of type
`roaring::RoaringBitmap`, so a `roaring` 0.x bump was a breaking change to
this crate and callers had to depend on a matching version to name the
type at all. The accessors speak in committee indices and in the
RoaringBitmap serialized form the BCS encoding already uses, which lets
`iota-sdk-crypto` and `iota-sdk-ffi` drop the dependency outright.

The wire format is unchanged — the BCS fixture, the serialization
proptests and the ABNF fuzzing all cover it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(types)!: make the growable public enums non_exhaustive

#487 marked most public enums but missed five that can gain variants:
`ObjectData` and `ObjectType` (the source comment under `ObjectData`'s two
variants already anticipates the IOTA-native types), and the three effects
enums, which the crate documents as its own view rather than a wire type.

`TypeTag`, `NameFormat` and the four Move mirrors in `iota-sdk-move-types`
stay exhaustive — Move pins those variant sets.

Co-Authored-By: Claude Opus 5 (1... (continued)

Coverage Stats

81 of 112 new or added lines in 6 files covered. (72.32%)

522 existing lines in 17 files now uncovered.

12104 of 29114 relevant lines covered (41.57%)

16016.54 hits per line