roundup-tracker / roundup / 34540344235

75%

push

github

Class.create sanity checks to hyperdb::Class.create from Class.create_inner

Move redundant database read/write mode check to hyperdb::Class.create
from rdbms_common::Class.create_inner() and
back_anydbm::Class.create_inner()

Also move reserved property name checks (on propvalues dict) from
create_inner() to create(). These checks are done after the auditors
run but before create_inner is called.

While doing this, opened issue2551428. Class.set() checks propvalues
and returns if it is empty. Should Class.create() do the same
returning None for newid?

If I test for empty propvalues in the create() path and just return,
the testKeyValue test fails. To keep this test working, I altered
testKeyValue. It now calls user.create() with the age property. It
will raise ValueError because the username key property is not
defined. But it will not trigger an error if the code changes to
handle create() with no propvalues.

Added an xfail test for case where we create an item in a class
that has no key property and does not set any properties. It's xfail
as I don't know what the right answer is.

4 of 4 new or added lines in 1 file covered. (100.0%)

19130 of 25407 relevant lines covered (75.29%)

5.23 hits per line