archetech / archon / 34506478875

92%

main: 87%

Pull #1107

github

fix(keymaster-service): Handle review — the 400 handler was being overwritten

Three issues from review:

- KeymasterServiceError is an alias of KeymasterError (runtime.py), so the
  separate exception handler for it registered the same class again and
  overwrote the new 400 handler with the old 500 one -- KeymasterError still
  returned 500. It is raised only at startup, never per-request, so its handler
  was removed; the base KeymasterError handler now stands and unexpected errors
  still reach the generic 500 handler. Confirmed against real FastAPI dispatch.

- The status tests called handlers directly and so could not see that
  overwrite. The stubbed FastAPI now records its registrations, and a new test
  asserts KeymasterError resolves to the 400 handler -- it fails if the
  colliding handler returns.

- README §16.3 overstated the 404 category: an explicit did: that fails to
  resolve raises the base KeymasterError (400), not UnknownIDError; only an
  unresolved name is 404. Narrowed the row and recorded the nuance, left to
  #1108 since fixing it changes the shared library's resolve_did.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

4084 of 4701 branches covered (86.88%)

Branch coverage included in aggregate %.

8766 of 9204 relevant lines covered (95.24%)

742.89 hits per line