umputun / agterm / 34504482777
94%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 136
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.837%. Remained the same
34504482777

push

github

web-flow 
fix(status): start status sounds off the main actor (#579)

status sounds started playback synchronously on the main actor. `StatusSoundPlayer` is `@MainActor` and `ControlServer.setSessionStatus` called `play(name)` inline, so a slow first `NSSound.play()` blocked the same thread that delivers keystrokes. That stalls typing in every session, not just the one that set the status.

#575 measured ~881ms for the first `play()` call itself, and ~739ms for a first blocked-status transition end to end. Why the call is slow was never established, so the comments here say what was measured and stop there.

playback now hops to a private static serial `DispatchQueue`. Serial so one clip's `stop()`/`play()` pair cannot interleave with another's on the same cached `NSSound`. `NSSound` is annotated `Sendable` in the SDK, so the production side needs no unchecked wrapper.

name resolution via `NSSound(named:)` still runs on the main actor. That is a scope decision, not a limit of the design: `session.status` validates the name before it mutates the indicator, and moving that off the main thread means reworking the ordering. The reporter's probe put resolution at ~4ms for a system sound, and it is cached after the first hit. Slow custom-file resolution, the second stall he demonstrated with a WebDAV mount, is still there.

the test asserts the mechanism rather than elapsed time. A recording `NSSound` subclass published under a unique name records which thread `stop()` and `play()` ran on, covering the cached and uncached named-sound paths. Reverting the hop puts both calls back on the main thread and both tests fail, with no audio device involved and nothing audible during a run. The test fixture is `@unchecked Sendable`; production is not.

Fix #575

10511 of 11322 relevant lines covered (92.84%)

3604105.06 hits per line

Jobs
ID Job ID Ran Files Coverage
1 34504482777.1 136
92.84
GitHub Action Run
Source Files on build 34504482777