cybertec-postgresql / vip-manager / 34482096606

91%

Build Type

push

github

Committed by web-flow

Commit Message

[+] Support IPv6 addresses on Windows (#424)

* [+] Support IPv6 addresses on Windows

configureAddress() fed the VIP to AddIPAddress() via
binary.LittleEndian.Uint32(c.VIP.AsSlice()). For an IPv6 address that
slice is 16 bytes, so the call silently received the first four of them,
and AddIPAddress is an IPv4-only Win32 API regardless. An IPv6 VIP on
Windows could not work.

Add the IPv6-capable iphlpapi calls (InitializeUnicastIpAddressEntry,
CreateUnicastIpAddressEntry, DeleteUnicastIpAddressEntry) and dispatch on
the address family, reusing windows.MibUnicastIpAddressRow from
golang.org/x/sys/windows. The handle needed to remove the address differs
per family, so BasicConfigurer now embeds a platform specific osState
instead of carrying a Windows-only NTE context on every platform.

Also drop sendPacketWindows(). It dialled "ip4:ethernet", which is not a
network Go knows, so the Windows gratuitous ARP has always failed. None is
needed: Windows runs Duplicate Address Detection and announces the address
to the link itself when it is added through these APIs, for both families.

Note that Is4() alone would miss a ::ffff:a.b.c.d VIP, which is an IPv4
address, so the dispatch tests that case too.

Adds basicConfigurer_windows_test.go, which had no counterpart before:
every function in basicConfigurer_windows.go is now covered, including
both add and delete failure paths.

* [-] rebuild the IPv4 netmask from its prefix length on Windows

getMask() picks the mask width from what netip reports, and a ::ffff:a.b.c.d
VIP is reported as IPv6, so the Windows IPv4 path could be handed a 16 byte
mask and read only its leading four bytes: a /64 silently became a /32.

Derive the mask from netmaskSize() instead, and refuse a prefix wider than /32
rather than passing a nonsense mask to AddIPAddress.

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

932 of 1028 relevant lines covered (90.66%)

1.4 hits per line