mbarbin / lunarpc / 34

98%

push

github

Remove ezcurl in favor of a direct curl-based HTTP client

We only ever used three of ezcurl's entry points -- `Ezcurl.t`,
`Ezcurl.with_client` and `Ezcurl.post` -- all from `Rpc_client`, and of the
response it hands back we read only `code` and `body`. Everything else it offers
went unused, and `curl` was already a direct dependency of this package.

Replace it with `Http_client`, a small synchronous client written straight
against the curl bindings.

The public API is unchanged: `rpc_client.mli` and `lunarpc_client.mli` are
untouched.

The error sexp loses one atom, because ezcurl returned `(code, Curl.strerror
code)` and we were rendering `strerror` twice; no expect test pins that text, as
it is libcurl-version dependent. The `User-Agent: curl` header that ezcurl set
for us is kept verbatim, since libcurl sends none of its own.

`Curl.init` does not perform `curl_global_init`, so the one-shot global init has
to stay.

34 of 34 new or added lines in 2 files covered. (100.0%)

2050 of 2200 relevant lines covered (93.18%)

5581.14 hits per line