kivy / python-for-android / 34477118346

63%

push

github

Add --extra-manifest-application-xml for injecting elements inside <application> (#3377)

There's currently no way to add an arbitrary child element (like a
<provider>, needed for e.g. a FileProvider) inside <application> in
the generated AndroidManifest.xml:

- --extra-manifest-xml writes at the <manifest> root, as a sibling
  of <application> -- a <provider> there is invalid, providers must
  be nested inside <application>.
- --extra-manifest-application-arguments only splices into the
  <application ...> opening tag's attribute list, so it can't hold a
  full child element either.

This is a real gap: a FileProvider (needed to hand another app, e.g.
a camera app, a content:// Uri instead of a file:// one and avoid
FileUriExposedException on API 24+) requires exactly this kind of
<provider> entry, and there's currently no supported way to add one
without patching the rendered manifest after the fact via a p4a.hook.

Adds --extra-manifest-application-xml, rendered immediately before
</application> in every bootstrap's manifest template, alongside the
two existing options.

Co-authored-by: Dennis <dennisyliang@gmail.com>
Co-authored-by: Mathias Lindström <8863149+kuzeyron@users.noreply.github.com>

1833 of 3176 branches covered (57.71%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

5418 of 8326 relevant lines covered (65.07%)

3.9 hits per line