hyperledger / fabric-x-committer / 34463154028

91%

Build Type

push

github

Committed by web-flow

Commit Message

[sidecar] Replace the relay's sync maps with single-owner tracking (#814)

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- Replace `blkNumToBlkWithStatus` with `inFlightBlocks`: the submitted
blocks awaiting
statuses always form a contiguous block-number window, so they are held
in a ring buffer
and looked up by index instead of by map probe. It also owns the
next-block-to-commit
counter, which used to be a separate relay field, so that invariant
lives in one place.
- Replace `txIDToHeight` with `txIDDedup`: a plain map owned solely by
`preProcessBlock`,
which evicts a committed block's TX IDs by watching that counter rather
than having the
status goroutine remove each ID as its status arrives. Nothing else
touches it, so it
needs no synchronization, and it holds only IDs now that no caller reads
the height back.
- Route a status by the (block number, TX number, TX ID) triple of its
ref, against the
tracked block's own `txs`, instead of by a global TX ID lookup. This
subsumes both
reconnect cases the previous check covered and additionally validates
the TX number,
  which the block-number-only check did not.
- Remove `activeBlocksCount`, which was written on every block and never
read.

The dedup window widens as a result: a TX ID is now held until its block
commits rather
than until its own status arrives, so a duplicate submitted in that gap
is rejected by the
relay, with a status that is not stored in the state DB and so is not
notified, rather than
by the VC. That window already existed for a TX whose status had not yet
arrived.

#### Additional details (Optional)

Per transaction, the status and mapping paths together drop from four
`sync.Map` operations
to one uncontended mutex, and the relay's own allocations fall from 26
to 23 per TX. The
gain grows with the size of the in-flight set, since that is what made
the map probes
expensive:

    BenchmarkMapBlockSize/blockSize=100     433.4k -> 448.6k t... (continued)

Coverage Stats

106 of 107 new or added lines in 5 files covered. (99.07%)

25 existing lines in 8 files now uncovered.

9346 of 10349 relevant lines covered (90.31%)

11177.13 hits per line