urwid / urwid / 34459162466

89%

Build Type

push

github

Committed by web-flow

Commit Message

Speed up the widget render hot paths (#1290)

Columns.get_column_sizes fills lists instead of index-keyed dicts, the
Columns and Pile sizing flag combinations are module constants rather
than rebuilt per element, and CompositeCanvas.rows and cols accumulate
in place, not over a generator.

CanvasCache.invalidate, CanvasCache.cleanup and Canvas.set_cursor use
dict.pop instead of contextlib.suppress, and CanvasCache.store no
longer builds a walk_depends closure per stored canvas.

apply_target_encoding calls str.encode instead of codecs.encode, and
reads the SO/SI byte forms from constants in escape.py instead of
encoding them again for every rendered text segment.

LayoutSegment.__init__ dispatches on the segment length once and
unpacks directly, dropping an unreachable ValueError branch.

ProgressBar builds its label Text once per widget instead of once per
render and renders it through nocache_widget_render_instance: that
canvas is overwritten and discarded, so caching it only cost a weakref,
a store and a cleanup.

No public API changes. Canvas content, canvas types, warnings and
exception messages are unchanged, verified by differential runs over
727 ProgressBar cases, 7270 Columns and LayoutSegment cases, and 42
full-screen render cases.

| changed path | avg time before | avg time after | percent change |
| --- | --- | --- | --- |
| urwid/canvas.py | 1.95 us | 0.99 us | -49.4% |
| urwid/text_layout.py | 0.37 us | 0.29 us | -23.3% |
| urwid/util.py + urwid/display/escape.py | 0.90 us | 0.66 us | -26.2% |
| urwid/widget/columns.py | 13.72 us | 12.37 us | -9.8% |
| urwid/widget/pile.py | 24.15 us | 22.09 us | -8.5% |
| urwid/widget/progress_bar.py | 30.26 us | 17.20 us | -43.2% |
| (whole tree) TUI screen render | 26.91 ms | 25.34 ms | -5.9% |

Coverage Stats

3484 of 5254 branches covered (66.31%)

Branch coverage included in aggregate %.

85 of 89 new or added lines in 6 files covered. (95.51%)

1 existing line in 1 file now uncovered.

9616 of 12536 relevant lines covered (76.71%)

7.91 hits per line