ooni / probe-cli / 34353061709

71%

master: 71%

Pull #1817

github

fix(echcheck): do not attempt a TLS handshake when the TCP connect failed

When the dial fails, conn is nil and tls.Client(nil, ...).HandshakeContext
panics inside crypto/tls. This is what users saw with min-ng.test.defo.ie
once its port 15443 stopped answering. Return the test keys after
recording the failed TCP connect instead; that is the measurement.

Adds a localhost regression test that dials a closed port with and
without GREASE. It panics without the fix.

Closes #1728

3 of 3 new or added lines in 1 file covered. (100.0%)

28705 of 40414 relevant lines covered (71.03%)

49.53 hits per line