solidjs / solid / 34420819791

72%

main: 89%

push

github

feat(signals): router-agnostic navigation attribution (OBSERVE.attribution.withOrigin) (#3332)

* feat(signals): router-agnostic navigation attribution via OBSERVE.attribution.withOrigin

A navigation in Solid 2 is a plain write to the location; the engine already
sees everything it costs (the hold behind route data, the re-runs, the
silence) but not that the writes were a navigation, or to which route.
withOrigin({ kind: "navigation", name, to, from, params }, fn) is the seam
where a router says so, around its write — the one router-specific line,
living in the router.

Core: withOrigin (twin of withInteraction) on OBSERVE.attribution, the
originStart/originEnd hooks, and one new hook, flushEnd, after flush()'s
drain loop so the engine has the "committed and effects ran" instant for
writes no transition held. Prod dist is byte-identical (the site and its
flag fold out).

Engine: "navigation" ChangeOrigin kind (name/to/from/params), frames that
nest under the enclosing interaction — including through an action step;
HoldEvent.origin and route-named SILENT_HOLD/LONG_HOLD actors with
data.navigation; one NavigationEvent per frame (navigations()) settled once
as committed / held (HoldEvent attached) / superseded; feedback().navigations
per route. Prod twin gains the empty queries.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* feat(signals): navigation redirects, late-bound refs, and an effect-reaching hold census

Three refinements to withOrigin before it lands, so the shape ships once:

- NavigationRef.redirect (hop depth) folds a redirect onto the pending
  navigation instead of superseding it: one NavigationEvent timed from the
  user's request, the abandoned destination in `redirects`, the same origin
  object on every write so the hold joins by identity, and formatOrigin
  reading "navigation to /login (redirected from /users/42)".
  feedback().navigations gains `redirected`.
- The ref is ... (continued)

518 of 788 branches covered (65.74%)

Branch coverage included in aggregate %.

771 of 1006 relevant lines covered (76.64%)

14.99 hits per line