openconfig / kne / 34401070644

44%

main: 44%

Build Type

Pull #747

github

Committed by kraney

Commit Message

Design review comments

1. **Deterministic Probe Selection in node.go:234-275**:
    * Sorted pb.Services map keys before iterating in node.go:234-275 to prevent non-deterministic probe selection when multiple services
    match preferred names.
2. **Pod Readiness Condition Check in cisco.go:619-658**:
    * Updated cisco.go:619-658 to inspect p[0].Status.Conditions for corev1.PodReady == corev1.ConditionTrue before returning node.
    StatusRunning, ensuring XRD (and other Cisco models) do not bypass readiness probes.
3. **Single-Stream Log Fetching & Shadowing Fix in cisco.go:636-690**:
    * Added cisco.go:663-677 which streams pod logs once into a buffer, replacing len with n in io.Copy(buf, podLogs).
    * Updated isNode8000eFailed and isNode8000eUp to operate directly on the fetched byte slice.
4. **Unit Tests in cisco_test.go**:
    * Added unit tests TestIsNode8000eFailed and TestIsNode8000eUp verifying pattern matches for Router failed to come up, FATAL sim:,
    and LoginTimeoutError.
    * Updated TestNodeStatus to verify node.StatusFailed on failure patterns and node.StatusPending when pod readiness condition is false
    or missing.
    * Updated TestCreate to assert ReadinessProbe is properly populated on the created pod container.
5. **Unit Tests in juniper_test.go:1042-1057**:
    * Updated TestCreate to verify ReadinessProbe on the created cPTX pod (matching Sonic and Ciena test patterns).

Pull Request Pull Request #747: Add a K8s readiness check for device pods.

Coverage Stats

83 of 89 new or added lines in 7 files covered. (93.26%)

4 existing lines in 1 file now uncovered.

5885 of 13365 relevant lines covered (44.03%)

0.5 hits per line