Qiskit / qiskit / 34398812923

88%

main: 88%

Build Type

Pull #16931

github

Committed by mtreinish

Commit Message

Add call instructions, so a program can hold several functions

A call instruction names a function by `FunctionId` and computes nothing itself, so one
stored body serves however many sites invoke it. `InstructionRole::Call` is the fourth role,
and the only one besides the two boundary roles that carries no `ProgramOp`.

A call may only name a function defined before the one holding it. The call graph is
therefore acyclic structurally, with nothing to traverse, and a callee is in bounds without
a separate check. A function has no identifier until a program holds it, so `add_call` takes
the callee's signature from its caller and checks the operands against it, and
`QuantumProgram::new` verifies the recorded types against the function actually named.
Nothing about the callee is stored: a call instruction's operand types and its own result
types are the contract as it was checked. Every function the program holds is verified, not
only those the entry point reaches, so evaluation resolves a call with no error path of its
own. A function the entry point cannot reach is accepted, and removing one is a pass rather
than a validity rule.

Both checks compare a declared type against an offered one, which `TensorType::admits`
answers: it is `Tensor::matches` with a type in place of the tensor, so a bounded axis
admits any size within its bound. The per-axis rule the two share moves onto `Dim::admits`.
A result a call declares must admit what its callee produces, because the instructions
reading that result were type-checked against the declared type.

A call instruction reports no built-in implementation, so a function holding one is not
locally evaluable by itself, and the program-level question walks the reachable functions
instead. `QuantumProgram::eval` settles that for every reachable function before anything
runs, then resolves each call against the program's functions as it walks. A function
reached through a call reports its failure through `FunctionEval... (continued)

Pull Request Pull Request #16931: Add call nodes to QuantumFunction

Coverage Stats

591 of 605 new or added lines in 4 files covered. (97.69%)

22 existing lines in 4 files now uncovered.

119485 of 135657 relevant lines covered (88.08%)

963686.37 hits per line