Lumieducation / H5P-Nodejs-library / 34388035780

84%

master: 84%

Pull #4614

github

fix(h5p-e2e): strengthen copy-paste image assertion and reuse-dialog visibility check

The round-trip copy/paste test only ever exercised plain text, missing
the base64 media-embedding path in the H5P clipboard payload - now
copies/pastes an image too and verifies it survives (alt text in the
editor, then the rendered <img> in the player).

The reuse-dialog localization test asserted German labels on a modal
that could still be fully transparent: H5P core's H5P.Dialog.open()
adds the h5p-open class (opacity: 1) inside a setTimeout(1), not
synchronously, so Playwright's toBeVisible() (which ignores opacity)
could pass before the fade-in ran. The test now waits for h5p-open
before asserting, so it actually verifies a shown modal.

Also drops the temporary pull_request trigger on e2e-nightly.yml added
to prove the full matrix pre-merge.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DbHA4osrXQuchCfdtuJfP2

1995 of 2580 branches covered (77.33%)

Branch coverage included in aggregate %.

4538 of 5182 relevant lines covered (87.57%)

6489.72 hits per line