bleedingdeacons / integrity-sharp / 34380898004

91%

push

github

fix: take the API key out of the example and stop pinning Host on a shared HttpClient (#17)

* fix: read the example CLI's credentials from the environment

The base URL and API key were literals in a tracked file in a public
repository, so two distinct live keys are in this repo's history:
int_920a465e... at HEAD and int_64f2033a... in 991b9ce2. Both must be
rotated - deleting the line does not unpublish them.

The literal also pointed at plaintext http://, so the key travelled in
the clear on whatever network the sample was run from.

Both values now come from INTEGRITY_BASE_URL and INTEGRITY_API_KEY and
the program stops if either is missing, so running the sample never
requires editing a tracked file.

* fix: stamp the Host header per request rather than on the HttpClient

The constructor set DefaultRequestHeaders.Host, which pins the value for
every request that HttpClient makes for the rest of its life - including
requests issued by unrelated components handed the same injected
instance. Construct two clients against different base URLs on one
shared HttpClient and the last one constructed silently wins for both,
intermittently and according to DI registration order.

The comment above it already claimed every header was stamped
per-request precisely so that sharing an HttpClient stayed idempotent.
Host is now resolved once in the constructor and applied in
ApplyRequestHeaders alongside the others, which is what that comment
said was happening. The WAF requirement it exists for is met either way.

7 of 7 new or added lines in 1 file covered. (100.0%)

717 of 787 relevant lines covered (91.11%)

18.81 hits per line