nats-io / nats.go / 34334346817

85%

Build Type

push

github

Committed by web-flow

Commit Message

[FIXED] Messages(): handle a reconnect that completes between Next calls (#2135)

* [FIXED] Messages(): handle a reconnect that completes between Next calls

The pull request accounting of a Messages() iterator was only reset on
reconnect if the same Next call had observed both the RECONNECTING and
the CONNECTED status change: isConnected was a local of Next. With Next
driven by a short NextMaxWait, the reconnect regularly completed between
two calls, the CONNECTED event was discarded, pending stayed at the batch
size and no new pull request was ever sent. The iterator then went silent
on a healthy connection, permanently, with Next returning ErrTimeout and
the server reporting no waiting pull requests.

Track the connection state in the status goroutine that lives as long as
the iterator, and only forward a CONNECTED that follows a RECONNECTING.
Next now treats every errConnected as a real reconnect. The status
forwards also select on done so the goroutine cannot block forever on a
full errs channel after Stop.

Add a regression test that restarts the server while Next is polled with
a 100ms NextMaxWait; it fails on main with 5 of 10 messages delivered.

Signed-off-by: Parham Alvani <parham.alvani@gmail.com>

* ci: retrigger flaky TestPullConsumerFetchRace

---------

Signed-off-by: Parham Alvani <parham.alvani@gmail.com>

Coverage Stats

16 of 19 new or added lines in 1 file covered. (84.21%)

8 existing lines in 2 files now uncovered.

12857 of 15168 relevant lines covered (84.76%)

46109.0 hits per line