PHPOffice / PHPPresentation / 34326321929

94%

push

github

Shapes : Add moveShape(), and say how shapes stack (#1002)

The collection of a container is written in order and stacks in that order -- the first shape is
at the back -- and there was no way to change that order but to rebuild the array and hand it to
`setShapeCollection()`, which is what the reporter of #866 does today. Remove-and-re-add is not a
substitute: `unsetShape()` is a bare `unset()`, so it leaves a hole in the keys.

`moveShape(AbstractShape $shape, int $index): self` is `moveSlide()` one level down, on the
`ShapeCollection` trait, so a slide, a slide layout, a slide master, a group and the note of a
slide all get it. The keys are reindexed first, because a hole makes a key say something other
than the place the shape sits in.

The usage page said nothing about stacking order at all; it now does.

8 of 8 new or added lines in 1 file covered. (100.0%)

11379 of 12089 relevant lines covered (94.13%)

72.36 hits per line