bleedingdeacons / integrity / 34297109663
91%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 15
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.628% (+0.6%) from 90.05%
34297109663

push

github

web-flow 
fix: stop WP_DEBUG switching off the HTTPS requirement (#72)

The transport check read

    get_option('integrity_require_https', true) && !is_ssl()
        && !(defined('WP_DEBUG') && WP_DEBUG)

so a debugging flag disabled a transport-security control. WP_DEBUG is
routinely left on for a staging site and not rarely on a live one while
something is being chased, and on any such install API keys travelled over
plain HTTP without complaint, with nothing in the admin saying so. The keys
are long-lived and permission-bearing.

INTEGRITY_ALLOW_INSECURE_TRANSPORT replaces it, matching the constants Reach
and Fellowship already carry for exactly this reasoning. Weakening the
control is now a deliberate edit to wp-config.php rather than a side effect
of turning debugging on.

The admin setting is untouched: integrity_require_https stays the supported
way for an administrator to make the decision on purpose. The constant is
the local-development hatch, deliberately kept off the settings screen so
nobody weakens transport security while clicking through options trying to
make a request work.

Anyone who was relying on WP_DEBUG to run Integrity over http locally needs
the new constant in wp-config.php. That is the point of the change rather
than a side effect of it, but it is a change to make on a laptop after
upgrading.

The WP_DEBUG regression is pinned by a test that defines it true and asserts
the request is still refused; both it and the constant's own test run in
separate processes, since define() is permanent and would otherwise leak
into everything that ran afterwards.

2698 of 2977 relevant lines covered (90.63%)

4.34 hits per line

Coverage Regressions

Lines Coverage ∆ File
14
93.6
2.18% integrity/integrity/src/Api/RestController.php
Jobs
ID Job ID Ran Files Coverage
1 34297109663.1 15
90.63
GitHub Action Run
Source Files on build 34297109663