Logflare / logflare / 34266249307-1

83%

Build Type

push

github

Committed by web-flow

Commit Message

mapper: only accept a supplied `severity_number` inside the OTEL 1-24 range (#3936)

* mapper: only accept a supplied severity_number inside the OTEL 1-24 range

`severity_number_alt` is a `uint8`, so `coerce_uint` saturates anything above
255 down to 255, and values between 25 and 255 passed through untouched. The
RowBinary encoder then asked only whether the value was non-zero, so any of
those won over the `severity_text` mapping and got written to the column. A
payload carrying `severity_number: 300` stored 255; one carrying 30 stored 30.

OTEL `SeverityNumber` defines 1-24, with 0 meaning UNSPECIFIED, so the encoder
now treats a supplied value as a severity only when it falls in that range and
otherwise uses the `severity_text` mapping. Behaviour for 1-24 and for 0 is
unchanged.

The three Elixir mirrors of the collapse rule are updated alongside it so the
fused-vs-separate parity property keeps holding. Those parity tests compare two
implementations of the same rule and so could never have caught this; the new
coverage asserts the encoded severity byte directly.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* mapper: add strict uint coercion so a non-integer `severity_number` falls back to `severity_text`

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* mapper: apply `:strict` coercion to `from_output` sources and reject strict + value_map at compile

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* mapper: saturate uint bignums instead of zeroing them and apply `:strict` to the root path

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

6 of 7 new or added lines in 2 files covered. (85.71%)

17 existing lines in 6 files now uncovered.

14706 of 17887 relevant lines covered (82.22%)

2062.67 hits per line