MapColonies / shigola / e49bd3dbc

57%

master: 44%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: delete the go-side geometry processing trees (MAPCO-11492) (#18)

* refactor: cut the last two callers of the geometry trees (MAPCO-11492)

Two symbols were all that reached the Go-side geometry packages from code
this server still runs, and both wanted less than they were calling.

replaceTokens reprojected the two BBOX corners with basic.Transform, which
dispatched over every geometry type in order to walk one down to its points.
The only geometries it was ever handed here were those two points, so the
walk was generality without a caller; transformPoint does the same job over
maths/webmercator directly. Its error text is lowercased and package-prefixed
on the way past, matching the rest of this package.

The CLI tile-name formatters called maths.Exp2, whose reason for existing was
a clamp on exponents above 63. Both call sites have already rejected any z
above shigola.MaxZ by the time they reach it, so the clamp is unreachable and
a shift says it more plainly.

TestTransformPoint pins the reprojection against values taken from
basic.Transform, so the swap is checkable rather than asserted. Worth noting
that it is also new coverage: every replaceTokens case uses a tile whose SRID
matches its layer's, so the cross-SRID pairs — the ones a WorldCRS84Quad map
against a 3857 layer actually takes — had no test at all before this.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor: delete the go-side geometry processing trees (MAPCO-11492)

Nothing in either binary has been able to reach this code since MAPCO-11490
moved encoding into the database and MAPCO-11491 retired the interface that
fed it. An import graph from cmd/shigola and cmd/shigola_lambda reaches none
of it: clipping, make-valid, hit-mapping, simplification, validation, the
point containers, the SVG debug drawing, the legacy basic-geometry types and
the conversion layer between them and go-spatial/geom.

19,372 lines of Go go with this, plus the fixtures... (continued)

Coverage Stats

26 of 31 new or added lines in 4 files covered. (83.87%)

2 existing lines in 1 file now uncovered.

5275 of 9735 relevant lines covered (54.19%)

130.77 hits per line