veeso / suppaftp / 34238691814

83%

Build Type

push

github

Committed by web-flow

Commit Message

feat!: make data streams finalize themselves (#175)

* feat!: make data streams finalize themselves

Move the control connection (reply reader and data-connection flag) of
every client behind an Arc<Mutex<..>> shared with a new TransferStream
returned by put_with_stream, append_with_stream, retr_as_stream and
custom_data_command. The stream closes its data socket and reads the
226/250 reply itself through finish(); a dropped stream does the same
(sync) or defers the reply to the next command (tokio, smol), so the
control connection can no longer desynchronize because a caller forgot
to finalize.

BREAKING CHANGE: finalize_put_stream, finalize_retr_stream and
close_data_connection are removed; put_with_stream, append_with_stream,
retr_as_stream and custom_data_command return TransferStream, whose
finish() replaces them; abort takes a TransferStream; the async retr
callbacks receive and return a TransferStream; get_ref returns a locked
ControlSocket (async: through an async fn); get_lines_from_stream is
generic over BufRead readers.

* fix: preserve transfer cleanup across cancellation and locking

Retain pending replies and partial response buffers when async finalization is cancelled. Record dropped transfers without locking the control channel and reject TLS mode changes before sending commands while a transfer is alive.

Add regression coverage for cancellation, control socket contention, and TLS transitions. Document the breaking stream API migration and cleanup limitations, and resolve test helper lint warnings.

* docs: move stream migration notes into commit description

Migrating to self-finalizing streams (unreleased)

The next major release changes the streaming API from version 11. The changes below
apply to this development branch and are not available in the published version 11.

- `put_with_stream`, `append_with_stream`, `retr_as_stream`, and
  `custom_data_command` return a `TransferStream` that owns transfer cleanup.
- Replace `ftp.fin... (continued)

Coverage Stats

1688 of 1878 new or added lines in 10 files covered. (89.88%)

6 existing lines in 3 files now uncovered.

6369 of 7680 relevant lines covered (82.93%)

174.47 hits per line