nbari / pg_exporter / 34237846773

90%

main: 90%

Build Type

push

github

Committed by nbari

Commit Message

strengthen blocking-read guard and cross-target lint coverage

Follow-up to the release review of the scrape-gate and OS-sampling fixes.

Guard: rewrite collectors_do_not_block_the_runtime_with_os_reads as a
per-file call-graph taint analysis instead of a flat source-text scan.
Markers are now derived from aliased OS imports as well as the pinned
literals, functions containing OS reads are propagated to their callers
to a fixpoint, and the offload_coalesced(...) argument region is scoped
by parenthesis depth. This closes two evasions the previous guard
allowed: hiding the read in a helper called inline from collect_once,
and reading through a renamed std::fs import.

CI: run cargo clippy for x86_64-unknown-freebsd and
x86_64-unknown-illumos in the lint job so the unsupported-platform cfg
arm is compiled on every push. The redundant Check (FreeBSD) step is
dropped from the check job.

Fix: the unsupported-platform read_cpu_times() returned Ok(Vec::new())
unconditionally and tripped clippy::unnecessary_wraps, which the new
illumos lint surfaced. The Result is load-bearing because
update_cpu_seconds distinguishes Ok(empty) from Err, so the lint is
allowed locally with a justification rather than changing the signature.

Docs: note in CHANGELOG.md and src/collectors/system/README.md that the
collector duration histogram _sum/_count include aborted scrapes, and
give the PromQL needed to read the real successful-scrape cost.

Coverage Stats

105 of 166 new or added lines in 1 file covered. (63.25%)

56 existing lines in 6 files now uncovered.

19910 of 23110 relevant lines covered (86.15%)

688.57 hits per line