akvo / african-bamboo-dashboard / 34237091906

92%

Build Type

push

github

Committed by ifirmawan

Commit Message

[#51] fix(sync): key submissions on kobo_id and drop uuid uniqueness

Follow-up to 7d2b44c, which fixed the wrong half of this. Neither Kobo
field is stable on its own, and each of the two previous attempts broke
the case the other handled:

  edit in Kobo -> _id stays, _uuid CHANGES   (4 of 128 rows, local)
  re-import    -> _id changes, _uuid stays   (row 272, production)

Keying on (form, kobo_id) broke on re-import: the new _id looked like a
new submission and collided with the existing row's uuid, which is the
500 first seen on aXE8NU3f8HrXmC5FL96HoD. Keying on (form, uuid) then
broke on edit, colliding on (form, kobo_id) instead -- the same failure
mirrored, on aNcUtA9q4obRGTq2mVGqXE.

Key on (form, kobo_id) and refresh uuid as data. _id is Kobo's own
operational identifier -- /data/<id> and update_validation_statuses both
use it -- and editing is by far the more common case.

The re-import case is already covered: the superseded _id disappears
from Kobo (verified against production), so the old row is picked up by
the stale sweep, blocked from approve/reject and offered for deletion,
rather than being silently carried forward.

Drop the (form, uuid) constraint added in 0016. uuid carries no
uniqueness in any scope: a re-import legitimately leaves two rows in one
form sharing an instance uuid until the sweep flags the superseded one.
0016 itself is left in place -- the looser constraint it produced is
correct, it just was not the fix.

get_object keeps both branches: 409 across forms, where the rows are
unrelated submissions and returning either would show the wrong form's
data; most-recent within a form, where the older row is a supersession
about to be flagged.

Measured rather than assumed, via kubectl into the backend pod. Three
earlier explanations -- cloned assets sharing uuids, duplicate _uuid in
the payload, and _uuid being the stable key -- were each plausible and
each wrong. Across all forms: 0 uuids shared between assets, 0 repeated
_... (continued)

Coverage Stats

4 of 5 new or added lines in 2 files covered. (80.0%)

1 existing line in 1 file now uncovered.

3862 of 4179 relevant lines covered (92.41%)

0.92 hits per line