calintamas / react-native-toast-message / 34219643275

100%

master: 100%

push

github

fix: re-run the slide animation when the target position changes (#606)

`translateY` is memoized on the target position, so it is rebuilt whenever
`keyboardHeight`, `bottomOffset` or `topOffset` changes. A rebuilt
interpolation is never driven though, because the layout effect that calls
`animate` depends only on `isVisible`, and `animate` itself is memoized on
`animationConfig`. The container therefore animates to its position once per
hide-to-show transition and keeps that transform for the rest of its life.

Two visible consequences:

- `avoidKeyboard` does nothing for a toast that is already on screen. The
  keyboard opens, the output range is recomputed, and the toast stays where
  it was, so the keyboard covers it.
- `Toast.show` called while a toast is visible keeps the previous toast's
  offset, because `isVisible` never flips. A caller that varies `bottomOffset`
  per screen gets the wrong one.

Adding the target-position inputs to that effect's deps drives the rebuilt
interpolation, and animates rather than jumps.

Measured on an iPhone 17 Pro simulator with `bottomOffset: 128` and a toast
pinned open: before, opening the keyboard left it at 706-746pt with the
keyboard top at 538pt; after, it moves to 488-528pt, which is
`screenHeight - max(bottomOffset, keyboardHeight + keyboardOffset)`. The
show-over-visible case is fixed on Android too, since it does not depend on
keyboard tracking.

134 of 134 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

248 of 248 relevant lines covered (100.0%)

48.62 hits per line