fernandobatels / rsfbclient / 34219335725

43%

master: 42%

Pull #189

github

Pure rust "connection rejected" regression fixed

76621aa(#179) made read_with() preserve unconsumed bytes across calls
instead of silently dropping them. That surfaced two latent bugs that
were previously harmless only because leftovers were discarded:
- execute2's closure called parse_response() right after
  parse_sql_response(), but the trailing op_response is framed with
  its own op_code like every other response on the wire. Skipping it
  left the response's own [op_code=9] sitting in pending, which the
  next read (e.g. commit_retaining) misread as the following
  operation's op_code, producing "Connection rejected with code 1
  (Connect)".
- parse_status_vector() had no arm for isc_arg_warning (18). Any
  status vector containing a warning (e.g. from CREATE USER) hit the
  catch-all "Invalid / Unknown status vector item" error before
  consuming the warning's code word, leaving pending misaligned for
  every subsequent read and cascading into garbage op_codes during
  rollback/detach.

0 of 5 new or added lines in 2 files covered. (0.0%)

2932 of 6748 relevant lines covered (43.45%)

194.92 hits per line